1101 Extend integrator classes and reimplement SDE models. #1296
Merged
1101 Extend integrator classes and reimplement SDE models. #1296
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1296 +/- ##
==========================================
+ Coverage 97.27% 97.35% +0.08%
==========================================
Files 171 174 +3
Lines 15117 15015 -102
==========================================
- Hits 14705 14618 -87
+ Misses 412 397 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@nijawa Could you double check that this PR solves the NaN issues (mathematically) correctly? |
HenrZu
requested changes
Jun 17, 2025
Contributor
HenrZu
left a comment
There was a problem hiding this comment.
code is great :) Some comments. Some functions are short in/missing documentation. Also consider the readthedocs doc. However, it would make sense to update this in the branch there.
reneSchm
commented
Jun 26, 2025
HenrZu
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
get_noise.If need be, add additional information and what the reviewer should look out for in particular:
Ordertemplate parameter, theget_noisefunction and theXdeIntegrator(maybe "DeIntegrator" or just "Integrator"?).Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #1009
Closes #1101
Closes #1165
Closes #1218