Merged
Conversation
2 tasks
HenrZu
requested changes
May 21, 2025
Contributor
HenrZu
left a comment
There was a problem hiding this comment.
i had a first brief look at most of the secir_simple functions. Lets discuss the points before you start working on this :) Looks really good, great work :)
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/data_generation.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/data_generation.py
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/data_generation.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/data_generation.py
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/grid_search.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/grid_search.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/hyperparameter_tuning.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/hyperparameter_tuning.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/hyperparameter_tuning.py
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/hyperparameter_tuning.py
Show resolved
Hide resolved
Co-authored-by: Henrik Zunker <69154294+HenrZu@users.noreply.github.com>
HenrZu
requested changes
Jun 2, 2025
Contributor
HenrZu
left a comment
There was a problem hiding this comment.
great work :) Some more comments. Regarding the ones about the secir groups. We can skip them and adress them in the next pull request since we only wanted to deal with the secir simple one and still need to rework the groups one.
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/model.py
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/model.py
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/model.py
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/model.py
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/model.py
Show resolved
Hide resolved
...e/memilio-surrogatemodel/memilio/surrogatemodel_test/test_surrogatemodel_ode_secir_simple.py
Outdated
Show resolved
Hide resolved
...e/memilio-surrogatemodel/memilio/surrogatemodel_test/test_surrogatemodel_ode_secir_simple.py
Show resolved
Hide resolved
...e/memilio-surrogatemodel/memilio/surrogatemodel_test/test_surrogatemodel_ode_secir_simple.py
Outdated
Show resolved
Hide resolved
...e/memilio-surrogatemodel/memilio/surrogatemodel_test/test_surrogatemodel_ode_secir_simple.py
Outdated
Show resolved
Hide resolved
...e/memilio-surrogatemodel/memilio/surrogatemodel_test/test_surrogatemodel_ode_secir_groups.py
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1252 +/- ##
==========================================
- Coverage 97.23% 97.21% -0.03%
==========================================
Files 155 167 +12
Lines 14278 14960 +682
==========================================
+ Hits 13883 14543 +660
- Misses 395 417 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HenrZu
requested changes
Jun 2, 2025
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_simple/network_architectures.py
Outdated
Show resolved
Hide resolved
Contributor
|
This also closes #849 |
2 tasks
HenrZu
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)