Skip to content

1243 Deactivate old github pages documentation#1244

Merged
jubicker merged 4 commits intomainfrom
1243-deactivate-old-github-pages
Apr 24, 2025
Merged

1243 Deactivate old github pages documentation#1244
jubicker merged 4 commits intomainfrom
1243-deactivate-old-github-pages

Conversation

@mknaranja
Copy link
Member

@mknaranja mknaranja commented Apr 7, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • With the new documentation, deactivate old github pages documentation

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (7be189b) to head (1f850ff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1244   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files         156      156           
  Lines       14674    14674           
=======================================
  Hits        14266    14266           
  Misses        408      408           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@kilianvolmer kilianvolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the pycode/build_pylint line removed and newly added? Is the indentation correct?

@jubicker jubicker merged commit 672cbc1 into main Apr 24, 2025
68 checks passed
@jubicker jubicker deleted the 1243-deactivate-old-github-pages branch April 24, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deactivate old github pages

3 participants