1195 Formatter for date to have consistent Format#1198
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1198 +/- ##
==========================================
+ Coverage 97.12% 97.21% +0.09%
==========================================
Files 148 154 +6
Lines 13782 14203 +421
==========================================
+ Hits 13386 13808 +422
+ Misses 396 395 -1 ☔ View full report in Codecov by Sentry. |
2 tasks
reneSchm
requested changes
Feb 13, 2025
Member
reneSchm
left a comment
There was a problem hiding this comment.
Very nice addition, makes the logging of dates a lot easier. Good tests too.
The changes requested are only small details.
In models/ide_secir/parameters_io.h:292-298 there are two more dates only used for a log_warning, could you replace them as well?
reneSchm
approved these changes
Feb 14, 2025
Member
reneSchm
left a comment
There was a problem hiding this comment.
All change requests are addressed (and comments further improved). Code cov fails due to missed lines, which
- were also not covered prior to this PR,
- and consist of logging related code, which we intentionally do not test in most cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)