Skip to content

1133 Change member functions in Model class from public to private in IDE model#1166

Merged
annawendler merged 2 commits intomainfrom
1133-change-member-functions-in-model-class-from-public-to-private-in-ide-model
Jan 6, 2025
Merged

1133 Change member functions in Model class from public to private in IDE model#1166
annawendler merged 2 commits intomainfrom
1133-change-member-functions-in-model-class-from-public-to-private-in-ide-model

Conversation

@annawendler
Copy link
Member

@annawendler annawendler commented Dec 19, 2024

Changes and Information

  • Make member functions that are required for simulating private
  • Define Simulation class and set_initial_flows() as friends

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1133

Copy link
Member

@lenaploetzke lenaploetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR, I guess this really prevents the model functions from being misused. :) I just have a few comments. Please also tick the boxes of the checks by author.

@annawendler annawendler merged commit 60a99ba into main Jan 6, 2025
53 of 54 checks passed
@annawendler annawendler deleted the 1133-change-member-functions-in-model-class-from-public-to-private-in-ide-model branch January 6, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change member functions in Model class from public to private in IDE model

2 participants