Skip to content

1121 LCT paper#1164

Closed
lenaploetzke wants to merge 16 commits intomainfrom
1121-lct-paper
Closed

1121 LCT paper#1164
lenaploetzke wants to merge 16 commits intomainfrom
1121-lct-paper

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Dec 16, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Added simulation scripts, shell scripts (to get all the data with one command), and plot scripts used to create the figures of the LCT paper.
  • I validated that the figures in the paper look the same as the outputs using these files.

If need be, add additional information and what the reviewer should look out for in particular:

  • I tried to document what is happening really detailed, such that my work can be easily continued. If I missed out anything, please comment.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1121

@lenaploetzke lenaploetzke added the model::lct Models using the linear chain trick label Dec 16, 2024
@lenaploetzke lenaploetzke self-assigned this Dec 16, 2024
@lenaploetzke lenaploetzke linked an issue Dec 16, 2024 that may be closed by this pull request
@mknaranja mknaranja changed the title 1121 lct paper 1121 LCT paper Dec 16, 2024
@codecov
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.98%. Comparing base (339768e) to head (c42a139).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1164   +/-   ##
=======================================
  Coverage   96.98%   96.98%           
=======================================
  Files         148      148           
  Lines       13783    13783           
=======================================
  Hits        13368    13368           
  Misses        415      415           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@annawendler
Copy link
Member

The simulation scripts, shell scripts and plot scripts have been merged into memilio-simulations, see SciCompMod/memilio-simulations#7 for the details. Hence, this PR can be closed.

@annawendler annawendler closed this Mar 4, 2025
@annawendler annawendler deleted the 1121-lct-paper branch March 4, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model::lct Models using the linear chain trick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simulation for age-resolved LCT model

2 participants