1144 handle case when group size is equal to 0 for the LCT model#1156
Merged
lenaploetzke merged 1 commit intomainfrom Dec 6, 2024
Conversation
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1156 +/- ##
==========================================
- Coverage 96.98% 96.96% -0.02%
==========================================
Files 142 142
Lines 11873 11874 +1
==========================================
- Hits 11515 11514 -1
- Misses 358 360 +2 ☔ View full report in Codecov by Sentry. |
Member
Author
|
I don't know what happened to the project coverage. Codecov marked an abm file, but that was not changed here. |
reneSchm
approved these changes
Dec 6, 2024
Member
reneSchm
left a comment
There was a problem hiding this comment.
The change looks good. I don't know what is up with the coverage, but this change does not impact tests (especially ones for the ABM).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #1144.