1019 Adjust memilio-generation for flow models and automatic differentiation#1153
Merged
MaxBetzDLR merged 37 commits intomainfrom Apr 28, 2025
Conversation
…ls, fixed pymio includes, added draw_sample binding, fixed flow_simulation and simulation bindings. Fixed the substitution in the generator. Added scalartype in intermediate_representation to set the type.
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1153 +/- ##
==========================================
- Coverage 97.23% 97.21% -0.02%
==========================================
Files 155 156 +1
Lines 14278 14674 +396
==========================================
+ Hits 13883 14266 +383
- Misses 395 408 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nerated when there is no AgeGroup in intermediate_representation.
…ATE, changed comment in utility
…ls-and-automatic-differentiation
…ls-and-automatic-differentiation
MaxBetzDLR
requested changes
Jan 22, 2025
pycode/memilio-generation/memilio/generation/intermediate_representation.py
Show resolved
Hide resolved
pycode/memilio-generation/memilio/generation/intermediate_representation.py
Outdated
Show resolved
Hide resolved
pycode/memilio-generation/memilio/generation_test/test_data/test_oseir.cpp.txt
Outdated
Show resolved
Hide resolved
pycode/memilio-generation/memilio/generation_test/test_oseir_generation.py
Outdated
Show resolved
Hide resolved
…there is only one config and the other parameters can be sett manualy
…r we use the generation-test folder
MaxBetzDLR
requested changes
Apr 7, 2025
Member
MaxBetzDLR
left a comment
There was a problem hiding this comment.
Good Code, minor changes to docs
2 tasks
MaxBetzDLR
approved these changes
Apr 28, 2025
Member
MaxBetzDLR
left a comment
There was a problem hiding this comment.
All requested changes were addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
-Scanner now checks for Flowmodel and Compartmentalmodel
-pymio includes fixed in template_string
-config.json does not need age_group, simulation and parameterset_wrapper annymore (scanner is setting those)
-added simulate and simulate_flows
-added interpolate_simulation_result and interpolate_ensemble_results
-added scalartype in intermediate_representation to set a datatype for bindings
If need be, add additional information and what the reviewer should look out for in particular:
-Check if the bindings are correct
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #1019