1148 Rework Data structure and Rename Mobility and Vaccination file#1150
Merged
1148 Rework Data structure and Rename Mobility and Vaccination file#1150
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1150 +/- ##
==========================================
- Coverage 97.21% 97.20% -0.02%
==========================================
Files 154 154
Lines 14203 14193 -10
==========================================
- Hits 13808 13796 -12
- Misses 395 397 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
Closed
2 tasks
Contributor
Author
|
To validate the changes, I ran the Simulation once in the current main and in this branch once in cpp and once in python while saving the graph and compared it then. The results are identical to the previous one. |
xsaschako
approved these changes
Mar 17, 2025
Member
xsaschako
left a comment
There was a problem hiding this comment.
Looks good to me. If you can answer the one question i'd be happy but i approve for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
all_county_ageinf_vacctovacc_county_ageinfgetSimulationDatato really provide all files to execute the simulations.If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)