Skip to content

1021 Error when compiling on Mac with new boost#1146

Merged
DavidKerkmann merged 4 commits intomainfrom
1021-error-when-compiling-on-mac-with-new-boost
Nov 26, 2024
Merged

1021 Error when compiling on Mac with new boost#1146
DavidKerkmann merged 4 commits intomainfrom
1021-error-when-compiling-on-mac-with-new-boost

Conversation

@reneSchm
Copy link
Member

@reneSchm reneSchm commented Nov 19, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Change compiler flag disabling warnings from boost depending on Clang version.
  • Treat compiler ID "AppleClang" as "Clang" and warn about it.
  • Change two occurrences of vector<bool> to array to sidestep a libc++ extension for const bool references in vector.

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@reneSchm reneSchm linked an issue Nov 19, 2024 that may be closed by this pull request
2 tasks
@reneSchm reneSchm self-assigned this Nov 19, 2024
@reneSchm reneSchm added the loc::backend This issue concerns the C++ backend implementation. label Nov 19, 2024
@codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.98%. Comparing base (bc417ce) to head (17ac917).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1146      +/-   ##
==========================================
+ Coverage   96.88%   96.98%   +0.09%     
==========================================
  Files         140      142       +2     
  Lines       11504    11868     +364     
==========================================
+ Hits        11146    11510     +364     
  Misses        358      358              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reneSchm reneSchm changed the title change ignored warning for possibly better portability 1021 Error when compiling on Mac with new boost Nov 19, 2024
@reneSchm reneSchm linked an issue Nov 26, 2024 that may be closed by this pull request
2 tasks
@DavidKerkmann DavidKerkmann merged commit c6e9f15 into main Nov 26, 2024
@DavidKerkmann DavidKerkmann deleted the 1021-error-when-compiling-on-mac-with-new-boost branch November 26, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

loc::backend This issue concerns the C++ backend implementation.

Projects

Status: Done (Total) 💯

Development

Successfully merging this pull request may close these issues.

ABM Serialization Tests don't build on Mac Error when compiling on Mac with new boost

2 participants