1138 plot functions for AST in generation package#1140
Merged
MaxBetzDLR merged 12 commits intomainfrom Nov 7, 2024
Merged
Conversation
…formatted. Class not complete
… the ast as png with a starting node and max depth, added get_node_by_index to search a node based on its index in the cursor_nodes list. Not complete.
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1140 +/- ##
=======================================
Coverage 96.59% 96.59%
=======================================
Files 137 137
Lines 11057 11057
=======================================
Hits 10680 10680
Misses 377 377
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MaxBetzDLR
reviewed
Oct 25, 2024
…added. Changes in graph_visualization, scanner and utility.
MaxBetzDLR
requested changes
Nov 4, 2024
Member
MaxBetzDLR
left a comment
There was a problem hiding this comment.
Looks good, just needs some small adjustments.
pycode/memilio-generation/memilio/generation/graph_visualization.py
Outdated
Show resolved
Hide resolved
pycode/memilio-generation/memilio/generation/graph_visualization.py
Outdated
Show resolved
Hide resolved
Member
|
The example still uses the old print function and scanner. Update the file and add the graphviz. |
Review changes.
MaxBetzDLR
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #1138