1117 reduce use of get support max method in ide model to reduce run time#1129
Merged
annawendler merged 12 commits intomainfrom Oct 1, 2024
Merged
Conversation
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1129 +/- ##
==========================================
+ Coverage 96.44% 96.59% +0.14%
==========================================
Files 135 137 +2
Lines 11285 11057 -228
==========================================
- Hits 10884 10680 -204
+ Misses 401 377 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lenaploetzke
requested changes
Sep 27, 2024
Member
lenaploetzke
left a comment
There was a problem hiding this comment.
Thank you for the nice work and the very impressive run time improvement!
I have some comments, especially, we should consider making the setters private member functions somehow. Maybe we can discuss this.
Co-authored-by: lenaploetzke <70579874+lenaploetzke@users.noreply.github.com>
lenaploetzke
reviewed
Oct 1, 2024
Member
lenaploetzke
left a comment
There was a problem hiding this comment.
Looks very good now, just a few typos and the header :)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #1117