1123 population data for different years#1124
Merged
Conversation
HenrZu
reviewed
Sep 17, 2024
Contributor
HenrZu
left a comment
There was a problem hiding this comment.
Thank you really much for the fast integration! Very nice as always :)
Only some short comments. And some tests would be great.
pycode/memilio-epidata/memilio/epidata_test/test_epidata_get_population_data.py
Show resolved
Hide resolved
Member
|
The incorrect population data makes our ESID scenario pipeline failing and this should be repaired soon. @patricklnz Are you still adding some unit tests as Henrik requested? That'd be great! Could you also provide some information on what you did in the issue? |
HenrZu
requested changes
Sep 23, 2024
HenrZu
approved these changes
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
-Population Data can now be downloaded for past years, specified with
ref_year-The test for total population has been adjusted to be 5% accurate to 8.4 million
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
closes #1123