Skip to content

1123 population data for different years#1124

Merged
HenrZu merged 7 commits intomainfrom
1123-population-data-for-different-years
Sep 25, 2024
Merged

1123 population data for different years#1124
HenrZu merged 7 commits intomainfrom
1123-population-data-for-different-years

Conversation

@patricklnz
Copy link
Member

@patricklnz patricklnz commented Sep 12, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

-Population Data can now be downloaded for past years, specified with ref_year
-The test for total population has been adjusted to be 5% accurate to 8.4 million

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

closes #1123

@patricklnz patricklnz marked this pull request as ready for review September 12, 2024 13:17
@patricklnz patricklnz requested a review from HenrZu September 12, 2024 13:20
@patricklnz patricklnz self-assigned this Sep 16, 2024
Copy link
Contributor

@HenrZu HenrZu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you really much for the fast integration! Very nice as always :)

Only some short comments. And some tests would be great.

@patricklnz patricklnz requested a review from HenrZu September 23, 2024 05:55
@mknaranja
Copy link
Member

mknaranja commented Sep 23, 2024

The incorrect population data makes our ESID scenario pipeline failing and this should be repaired soon.

@patricklnz Are you still adding some unit tests as Henrik requested? That'd be great! Could you also provide some information on what you did in the issue?
@HenrZu Did you do a full review? Could you otherwise please do soon?

Copy link
Contributor

@HenrZu HenrZu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, however some unit tests would still be fine. Also, the param ref_year is only mentioned in the parameters. It would be cool if you could add some more documentation :)

@patricklnz patricklnz requested a review from HenrZu September 25, 2024 10:43
@HenrZu HenrZu merged commit 32cd836 into main Sep 25, 2024
@HenrZu HenrZu deleted the 1123-population-data-for-different-years branch September 25, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Population data download for different years

3 participants