Skip to content

1092 add warning for end_date later than 2024-07-21 in divi data#1094

Merged
mknaranja merged 2 commits intomainfrom
1092-add-warning-for-end_date-later-than-2024-07-21-in-divi-data
Aug 9, 2024
Merged

1092 add warning for end_date later than 2024-07-21 in divi data#1094
mknaranja merged 2 commits intomainfrom
1092-add-warning-for-end_date-later-than-2024-07-21-in-divi-data

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Aug 7, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Added warning for end_date later than 2024-07-21 in divi data as it has been announced that the data will no longer be updated after that date.

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1092.

@lenaploetzke lenaploetzke added loc::data handling This issue concerns any kind of data handling. class::improvement Cleanup that doesn't affect functionality labels Aug 7, 2024
@lenaploetzke lenaploetzke self-assigned this Aug 7, 2024
@lenaploetzke lenaploetzke linked an issue Aug 7, 2024 that may be closed by this pull request
2 tasks
@lenaploetzke lenaploetzke requested a review from mknaranja August 7, 2024 09:27
Co-authored-by: Martin J. Kühn <62713180+mknaranja@users.noreply.github.com>
@lenaploetzke lenaploetzke requested a review from mknaranja August 8, 2024 06:28
@mknaranja mknaranja merged commit 717c026 into main Aug 9, 2024
@mknaranja mknaranja deleted the 1092-add-warning-for-end_date-later-than-2024-07-21-in-divi-data branch August 9, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::improvement Cleanup that doesn't affect functionality loc::data handling This issue concerns any kind of data handling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add warning for end_date later than 2024-07-21 in DIVI data

2 participants