Skip to content

workaround for github action checkout@v3#1063

Merged
dabele merged 2 commits intomainfrom
no-issue-fix-ci-manylinux
Jul 4, 2024
Merged

workaround for github action checkout@v3#1063
dabele merged 2 commits intomainfrom
no-issue-fix-ci-manylinux

Conversation

@dabele
Copy link
Member

@dabele dabele commented Jul 4, 2024

Changes and Information

deploy workaround from actions/checkout#1590 (comment) for github action checkout@v3.
can probably be removed when fixing #939

Quick fix, no linked issue.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@dabele dabele added class::bug Bugs found in the software prio::critical The priority of this task is very high. This issue is critical for continuation. loc::continuous integration This issue concerns any problem of continuous integration. labels Jul 4, 2024
@dabele dabele self-assigned this Jul 4, 2024
@dabele dabele requested a review from reneSchm July 4, 2024 08:43
@codecov
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (d439941) to head (0a99343).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1063   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files         127      127           
  Lines       10886    10887    +1     
=======================================
+ Hits        10477    10478    +1     
  Misses        409      409           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems okay for now, as @MaxBetzDLR is already working on a fix in #995.

@dabele dabele merged commit 3da5874 into main Jul 4, 2024
@dabele dabele deleted the no-issue-fix-ci-manylinux branch July 4, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::bug Bugs found in the software loc::continuous integration This issue concerns any problem of continuous integration. prio::critical The priority of this task is very high. This issue is critical for continuation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants