946 implement generalized linear chain trick#1058
Merged
annawendler merged 34 commits intomainfrom Nov 26, 2024
Merged
Conversation
…el' into 946-implement-generalized-linear-chain-trick
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1058 +/- ##
==========================================
+ Coverage 96.59% 96.98% +0.39%
==========================================
Files 137 142 +5
Lines 11057 11868 +811
==========================================
+ Hits 10680 11510 +830
+ Misses 377 358 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
annawendler
requested changes
Oct 11, 2024
Member
annawendler
left a comment
There was a problem hiding this comment.
This is a very cool model! I think it would benefit from adding more documentation to make it easier to understand.
Co-authored-by: annawendler <106674756+annawendler@users.noreply.github.com>
annawendler
reviewed
Nov 26, 2024
Member
annawendler
left a comment
There was a problem hiding this comment.
Looks good, just some comments regarding spelling :)
annawendler
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #946.