1038 OdeIntegrator can run indefinitely v2#1049
Merged
Conversation
12 tasks
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1049 +/- ##
==========================================
- Coverage 96.23% 96.21% -0.02%
==========================================
Files 128 128
Lines 10852 10867 +15
==========================================
+ Hits 10443 10456 +13
- Misses 409 411 +2 ☔ View full report in Codecov by Sentry. |
HenrZu
requested changes
Jun 13, 2024
Contributor
HenrZu
left a comment
There was a problem hiding this comment.
First feedback. Need some more time to check/ verify everything
Member
lenaploetzke
left a comment
There was a problem hiding this comment.
Nice work! I think this solution is much better than the first version. I only have a few small comments.
HenrZu
requested changes
Jun 21, 2024
lenaploetzke
approved these changes
Jun 25, 2024
HenrZu
approved these changes
Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)