992 download boost libs with URL instead of git repo#1048
Merged
Conversation
URL download is much faster
reneSchm
reviewed
Jun 7, 2024
reneSchm
approved these changes
Jun 7, 2024
Member
reneSchm
left a comment
There was a problem hiding this comment.
Those new build times look great! We went from around 15 minutes down to about 3 for the linux builds in only two patches.
I have no objections, we can merge this once the CI passes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1048 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 128 128
Lines 10852 10852
=======================================
Hits 10443 10443
Misses 409 409 ☔ View full report in Codecov by Sentry. |
Member
|
@reneSchm @dabele What's the time reduction for download itself? @lenaploetzke just FYI :) |
Member
Author
archive download is a < 10 secs, git clone is 1-2 mins, rough estimate, I didn't measure exactly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Download boost libs from a URL instead of git repository, archive download is much faster. Removed the bootstrapping code. With this increased speed, a minimal boost version is not necessary and not worth the maintenance.
Results from CI: compile times (with ccache and boost URL download) are down to ~4 mins, before they were at 20+. Obviously depends on many ccache hits and misses there are.
Not using the URL from github (e.g. https://github.com/boostorg/boost/archive/refs/tags/boost-1.84.0.tar.gz) since those archives don't actually contain the source code. I think the archive generation is automated, but the boost repo requires more setup before it is complete (subrepos, bootstrapping).
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Closes #992
Checks by code author
Checks by code reviewer(s)