496 Implement deterioration of mask with mask time used#1043
Closed
khoanguyen-dev wants to merge 6 commits intomainfrom
Closed
496 Implement deterioration of mask with mask time used#1043khoanguyen-dev wants to merge 6 commits intomainfrom
khoanguyen-dev wants to merge 6 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1043 +/- ##
==========================================
- Coverage 96.24% 96.23% -0.01%
==========================================
Files 127 127
Lines 10887 10868 -19
==========================================
- Hits 10478 10459 -19
Misses 409 409 ☔ View full report in Codecov by Sentry. |
Member
DavidKerkmann
left a comment
There was a problem hiding this comment.
Nothing to change necessarily, just two comments to think about. Make of them what you feel is best!
| /** | ||
| * @brief Effectiveness of a Mask of a certain MaskType% against an Infection% for the mask wearer. | ||
| */ | ||
| struct InwardMaskProtection { |
Member
There was a problem hiding this comment.
Keep in mind that this might have the same problems as the defaults for the protection levels in issue #1068 .
| } | ||
| } | ||
|
|
||
| if (this->get<MaskProtection>()[MaskType::Community] < 0.0 || |
Member
There was a problem hiding this comment.
Instead of checking these fix values, we could check for some reasonable time point arguments to the function if the result is between 0 and 1. Just an idea though for you to think about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #496