Skip to content

1034 ide model simulation does not work under some conditions#1035

Merged
annawendler merged 1 commit intomainfrom
1034-ide-model-simulation-does-not-work-under-some-conditions
May 15, 2024
Merged

1034 ide model simulation does not work under some conditions#1035
annawendler merged 1 commit intomainfrom
1034-ide-model-simulation-does-not-work-under-some-conditions

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented May 15, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • compute_compartment_from_flows() now works when the TransitionDistribution SusceptibleToExposed is set to a ConstantFunction (or any other function with an invalid maximum support).
  • fixed missing space in error message

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1034.

@lenaploetzke lenaploetzke self-assigned this May 15, 2024
@lenaploetzke lenaploetzke linked an issue May 15, 2024 that may be closed by this pull request
2 tasks
@lenaploetzke lenaploetzke requested a review from annawendler May 15, 2024 08:17
@codecov
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (e15b4bb) to head (d4d6ec8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1035   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files         130      130           
  Lines       10360    10364    +4     
=======================================
+ Hits         9990     9994    +4     
  Misses        370      370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenaploetzke lenaploetzke requested a review from annawendler May 15, 2024 11:26
@annawendler annawendler merged commit abc02d7 into main May 15, 2024
@annawendler annawendler deleted the 1034-ide-model-simulation-does-not-work-under-some-conditions branch May 15, 2024 12:04
reneSchm pushed a commit that referenced this pull request May 24, 2024
compute_compartment_from_flows() now works when the TransitionDistribution SusceptibleToExposed is set to a ConstantFunction (or any other function with an invalid maximum support).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IDE model simulation does not work under some conditions

2 participants