Skip to content

1022 wrong compiler version in ci for gcc#1023

Merged
mknaranja merged 17 commits intomainfrom
1022-wrong-compiler-version-in-ci-for-gcc
May 17, 2024
Merged

1022 wrong compiler version in ci for gcc#1023
mknaranja merged 17 commits intomainfrom
1022-wrong-compiler-version-in-ci-for-gcc

Conversation

@MaxBetzDLR
Copy link
Member

@MaxBetzDLR MaxBetzDLR commented Apr 29, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Use gcc/gxx-11 in CI
  • Update Readme

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1022

@MaxBetzDLR MaxBetzDLR linked an issue Apr 29, 2024 that may be closed by this pull request
2 tasks
@MaxBetzDLR MaxBetzDLR changed the title fix version 1022 wrong compiler version in ci for gcc Apr 29, 2024
@codecov
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (bcfa8d3) to head (9e6b4b6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1023      +/-   ##
==========================================
- Coverage   96.51%   96.23%   -0.29%     
==========================================
  Files         128      128              
  Lines       10538    10852     +314     
==========================================
+ Hits        10171    10443     +272     
- Misses        367      409      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change in the Readme, the rest looks good to me.

The change in abm_braunchschweig makes a lot of sense - I just removed the save_result_result in another branch as it was effectively unused, but stopping the entire ensemble because a singular output failed is likely not desirable. This here is better.

@mknaranja mknaranja merged commit 575a146 into main May 17, 2024
@mknaranja mknaranja deleted the 1022-wrong-compiler-version-in-ci-for-gcc branch May 17, 2024 12:06
reneSchm added a commit that referenced this pull request May 24, 2024
Co-authored-by: Martin J. Kühn <62713180+mknaranja@users.noreply.github.com>
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wrong compiler version in CI for gcc

3 participants