Skip to content

981 Fix failing RKI urls#1007

Merged
patricklnz merged 5 commits intomainfrom
981-change-failing-urls
Apr 25, 2024
Merged

981 Fix failing RKI urls#1007
patricklnz merged 5 commits intomainfrom
981-change-failing-urls

Conversation

@patricklnz
Copy link
Member

@patricklnz patricklnz commented Apr 18, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • change url from testing data and adjust script
  • delete getCaseDataWithEstimations

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #981

@patricklnz patricklnz self-assigned this Apr 18, 2024
@codecov
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (65f0b3f) to head (800c88a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1007   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         129      129           
  Lines       10071    10072    +1     
=======================================
+ Hits         9703     9704    +1     
  Misses        368      368           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patricklnz patricklnz requested a review from jubicker April 22, 2024 07:45
@patricklnz patricklnz merged commit b3895a4 into main Apr 25, 2024
@patricklnz patricklnz deleted the 981-change-failing-urls branch April 25, 2024 10:55
reneSchm pushed a commit that referenced this pull request May 24, 2024
+ delete getCaseDataWithEstimations.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RKI urls changed

2 participants