965 use int instead of unsigned int in lct infection state

[lenaploetzke]

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

• Ints instead of unsigned ints are now used in the LctInfectionState class.

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

• Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
• New code adheres to coding guidelines
• No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
• Tests are added for new functionality and a local test run was successful (with and without OpenMP)
• Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
• Proper attention to licenses, especially no new third-party software with conflicting license has been added
• (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

• Corresponding issue(s) is/are linked and addressed
• Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
• Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
• No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
• On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #965

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (29cf76b) to head (d53a2f0).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1002      +/-   ##
==========================================
- Coverage   96.34%   96.34%   -0.01%     
==========================================
  Files         129      129              
  Lines       10065    10064       -1     
==========================================
- Hits         9697     9696       -1     
  Misses        368      368              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[reneSchm]

Looks good, but please check that all Ns are positive (non-negative?) - I think there is an assert for that, but please make sure.

[lenaploetzke]

Looks good, but please check that all Ns are positive (non-negative?) - I think there is an assert for that, but please make sure.

Yes there was already a static_assert(((Ns > 0) && ...),) thing in line 43 of lct_infection_state.h for that because we actually need that the Ns are at least one.

[reneSchm]

Neat.