Conversation
Member
Author
|
All in all, my suggestions are far from complete but I think this is a first approach that could be merged. @Philou31 Could you have a quick look if you like my suggestion? Better ideas or modifications proposed? How about the many commented lines of output (in particular disp()). Do we remove or uncomment and integrate them? @CodingAllan Can you have a check that I did not introduce any new error? |
658d37e to
abd00c1
Compare
CodingAllan
reviewed
Jul 25, 2023
CodingAllan
reviewed
Jul 25, 2023
CodingAllan
reviewed
Jul 25, 2023
CodingAllan
reviewed
Jul 25, 2023
CodingAllan
reviewed
Aug 3, 2023
Philou31
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
[ ] The following questions are addressed in the documentation (if need be):
Developers (what did you do?, how can it be maintained?)
For users (how to use your work?)
For admins (how to install and configure your work?)
For documentation: Please write or update the Readme in the current working directory!
Checks by code reviewer(s):
Closes #36