Conversation
cbrady
force-pushed
the
chris/schy-45-datastreamreplicator-for-python
branch
from
cf3013c to
69d2a75
Compare
There was a problem hiding this comment.
Can we avoid checking in the wasm file? I remember we had a similar convo about this during one of the last SDKs, my though was that since we have another repo responsible for producing that wasm binary, we should be able to pull it in at build time.
Related - we should probably figure out a way to do some kind of build test, as I'm not certain how the packaging and publishing system here determines which files to include. We need to make sure that the wasm file, however we pull it in, ends up getting shipped with the published Python package.
cbrady
force-pushed
the
chris/schy-45-datastreamreplicator-for-python
branch
from
8214655 to
fd7ddf5
Compare
bpapillon
left a comment
bpapillon
left a comment
There was a problem hiding this comment.
I think our goal here should be to get to feature parity across the SDKs aside from OpenFeature which we can ignore, and parameter defaults which we've discussed separately we can do a sweep after this to get into alignment. So we should implement check_flags here as well.
Also, let's comp the test cases against reference implementations like Node, Ruby, Go - I think we are lighter here.
| if not self._replicator_health_url: | ||
| return | ||
| try: | ||
| import httpx |
There was a problem hiding this comment.
IMO we should import this at the top of the file and reuse a client for these health checks
2 participants
No description provided.