Open
Conversation
bpapillon
requested changes
Apr 2, 2026
Contributor
bpapillon
left a comment
bpapillon
left a comment
There was a problem hiding this comment.
We should try to normalize parameters - as I mentioned in the Ruby PR yesterday, we have some inconsistencies already that we should align, but as we roll out now SDKs we should try to align these better. In this case, the entity request timeout, flag cache TTL, and event retry timing parameters look different from other SDKs.
A few other notes:
- we should be sending a flag check event after client-side flag checks
- I think we're missing optimistic event updates here
- cache providers in other SDKs have delete and deleteMissing which are not present here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.