feat(threads): implement thread side panel with full functionality#123
Open
Just-Insane wants to merge 26 commits intoSableClient:devfrom
Open
feat(threads): implement thread side panel with full functionality#123Just-Insane wants to merge 26 commits intoSableClient:devfrom
Just-Insane wants to merge 26 commits intoSableClient:devfrom
Conversation
Just-Insane
force-pushed
the
feat/threads
branch
7 times, most recently
from
bc59926 to
fe82ee7
Compare
Contributor
Author
|
Also Fixes #124 - Use the SDK's notification options, will properly respect user's notification settings. |
Just-Insane
force-pushed
the
feat/threads
branch
from
fe82ee7 to
fa71c0a
Compare
added 7 commits
March 10, 2026 11:08
- Add device capability detection using same logic as sliding sync - Implement background pagination on room open with adaptive limits: - High-end (4g+/desktop/high-memory): 500 messages, 1s delay - Medium (3g or <=4GB RAM): 250 messages, 2s delay - Low-end (save-data/2g or mobile): 100 messages, 3s delay - Detection based on: connection type, device memory, save-data preference - Improves message history availability without blocking initial room load - Consistent with sliding sync's adaptive behavior
- Export AdaptiveSignals type and readAdaptiveSignals() from device-capabilities.ts - Update slidingSync.ts to import shared logic instead of duplicating it - Single source of truth for device capability detection across the app - Reduces code duplication and ensures consistent behavior
- Add ThreadDrawer component with message rendering and input - Add ThreadBrowser panel for viewing all threads in a room - Add thread chips on messages showing reply count and participants - Enable message actions in threads (edit, react, reply, delete) - Add emoji and sticker rendering support in threads - Filter thread replies from main timeline to avoid duplicates - Auto-create Thread objects when starting threads or syncing from other devices - Add unread thread badge to header icon (Discord-style) - Auto-open thread drawer when navigating to thread events from notifications - Reorder room header icons: search, pinned, threads, widgets, members, more - Add automatic read receipts when viewing threads Fixes thread browser showing empty list and inbox notifications not opening threads.
- Move readAdaptiveSignals import to top with other imports - Fixes unconventional import placement from previous refactor
…nation Add actual scroll position check (150px threshold) to ResizeObserver forceScroll to prevent it from forcing scroll to bottom when back paginating. During back pagination, messages load at the top causing content resize, but if atBottomRef hasn't updated yet from the scroll, it would incorrectly scroll to bottom. Now checks both: atBottomRef.current AND distance from bottom < 150px before forcing scroll, ensuring back pagination doesn't get interrupted.
Remove ThreadMockupPage and related route - no longer needed as threads are fully implemented.
Just-Insane
force-pushed
the
feat/threads
branch
from
fa71c0a to
1d65bfa
Compare
added 4 commits
March 10, 2026 14:27
The thread mockup feature was removed in previous commits but the button and navigation code remained in WelcomePage.tsx, causing build failures. This removes: - Thread mockup button from welcome page - Unused useNavigate import and hook call
Member
|
A few issues I found, not sure which ones overlap with #124 :
Also, maybe we should align the editor at the bottom with the main editor? Looks a bit weird having it lower down. |
added 2 commits
March 11, 2026 22:17
- Add PushProcessor for notification highlights - Add Reply component support for in-thread replies - Add message forwarding props support - Add send status handling (resend/delete failed sends) - Add memoized linkifyOpts and htmlReactParserOptions - Add developer tools and read receipts support - Bring full feature parity with RoomTimeline event rendering
Add key and data-message-id attributes to Message component in threads to enable proper hover effects and message identification.
added 5 commits
March 11, 2026 22:35
- Add messageList class with hover styles to ThreadDrawer.css.ts - Apply messageList class to root message and replies containers - Update padding to match RoomTimeline: S600 vertical spacing - Fix input alignment: change from S200 to S400 horizontal padding
Don't add m.in_reply_to for regular thread messages, only for actual replies within threads. Thread messages now use is_falling_back: true per Matrix spec, and replies within threads use is_falling_back: false.
Add thread relation to reply drafts in threads so replies are properly associated with the thread root event.
- Remove horizontal line separators to match room timeline - Align header left padding (S400) with messages and input - Update reply count label padding to match spacing system (S200/S400) - Remove unused Line import
- Increase header size from 400 to 600 to align bottom border with room header - Reduce root message and replies padding from S600 to S400 vertically - Add bottom border separator after root message section (ThreadRootSection) - Add bottom border separator after reply count label (ThreadReplyCountSection) - Add following indicator below thread input, filtered to thread participants only - Update RoomViewFollowing to accept optional threadEventId and participantIds props
added 3 commits
March 12, 2026 00:21
Contributor
Author
These should all be fixed now, if you want to test? |
added 4 commits
March 12, 2026 08:29
…matrix.ts - Fix import formatting in ThreadDrawer.tsx - Change onResend/onDeleteFailedSend to accept MatrixEvent instead of string - Remove unused variables (mx, autoplayEmojis) - Fix variable shadowing issue (renamed nicknames to localNicknames) - Format JSX props and code blocks per prettier rules - Remove unused eslint-disable directive - Fix trailing whitespace in RoomInput.tsx - Format function arguments in matrix.ts
- Remove unused autoplayEmojis variable - Format htmlReactParserOptions dependency array to single line - Remove unnecessary 'room' dependency from handleDeleteFailedSend - Remove unnecessary type assertion from querySelector - Format querySelector template string to single line - Format latestThreadEventId ternary expression
…read indicator - Add shrink="No" to reply count Box to prevent it from moving up as messages are added - Remove threadRootId prop from Reply component in thread view to hide redundant thread indicator icon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Matrix thread support with side panels, browser, and notification integration.
Features
Implementation Details
room.createThread(),room.getThreads())thread.getEventReadUpTo()andthread.hasCurrentUserParticipatedRelated
Future enhancement tracked in #124 to leverage SDK's thread-specific notification APIs (getThreadUnreadNotificationCount(),hasThreadUnreadNotification()).