model: fix edge case for Edm.DateTimeOffset.from_json() without offset#232
Merged
phanak-sap merged 1 commit intomasterfrom Sep 27, 2022
Merged
model: fix edge case for Edm.DateTimeOffset.from_json() without offset#232phanak-sap merged 1 commit intomasterfrom
phanak-sap merged 1 commit intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #232 +/- ##
=======================================
Coverage 92.34% 92.34%
=======================================
Files 6 6
Lines 2847 2849 +2
=======================================
+ Hits 2629 2631 +2
Misses 218 218 ☔ View full report in Codecov by Sentry. |
We were expecting that the offset part is mandatory and that the service should return /Date(1659430517461+0000)/ for offset set to UTC. Unable confirm in odata.org and W3C specifications, but some services works for this Edm type as offset is not mandatory of UTC timezone. Now, if the offset part is missing in incoming JSON payload, it should work as if +0000 was provided. FIXES #231
phanak-sap
force-pushed
the
issue-231
branch
from
2865f22 to
fb21cad
Compare
jfilak
approved these changes
Sep 27, 2022
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were expecting that the offset part is mandatory and that the service should return /Date(1659430517461+0000)/ for offset set to UTC. Unable confirm in odata.org and W3C specifications, but some services (SAP included) works for this Edm type as if offset is not mandatory for the UTC timezone.
Now, if the offset part is missing in incoming JSON payload, it should work as if +0000 was provided.
FIXES #231