Skip to content

fix: [OpenAPI] Remove generated no args constructor#1128

Merged
CharlesDuboisSAP merged 2 commits intomainfrom
🚫no-args-constructor
Mar 27, 2026

Hidden character warning

The head ref may contain hidden characters: "\ud83d\udeabno-args-constructor"
Merged

fix: [OpenAPI] Remove generated no args constructor#1128
CharlesDuboisSAP merged 2 commits intomainfrom
🚫no-args-constructor

Conversation

@CharlesDuboisSAP
Copy link
Copy Markdown
Contributor

Context

SAP/ai-sdk-java-backlog#378.

The no args constructor in generated API clients only connects to localhost which is useless and adds confusion.

Feature scope:

  • OpenAPI Apache Generator: Remove no args constructor in generated API clients.

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Documentation updated
  • Release notes updated

@CharlesDuboisSAP CharlesDuboisSAP self-assigned this Mar 27, 2026
@CharlesDuboisSAP CharlesDuboisSAP added please merge Request to merge a pull request please review Request to review a pull request labels Mar 27, 2026
@CharlesDuboisSAP CharlesDuboisSAP enabled auto-merge (squash) March 27, 2026 12:57
Copy link
Copy Markdown
Contributor

@newtork newtork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No breaking changes.

Copy link
Copy Markdown
Contributor

@newtork newtork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming no one is using the generated no-args constructor yet.

@CharlesDuboisSAP CharlesDuboisSAP merged commit cf7cdcd into main Mar 27, 2026
13 checks passed
@CharlesDuboisSAP CharlesDuboisSAP deleted the 🚫no-args-constructor branch March 27, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

please merge Request to merge a pull request please review Request to review a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants