Merged
Conversation
This is useful in the implementation of `aes-gcm-siv`, as it allows for calling the newly re-added `finalize_reset` method, which is useful to avoid consuming `self` when computing the tag. SIV mode encryption requires first computing the tag as a pass of POLYVAL over the plaintext, where the tag also functions as a synthetic initialization vector. With AES-GCM-SIV specifically, it also needs access to the original nonce, which is XORed into the tag. Consuming `self` means it's not possible to store the cipher, POLYVAL, and nonce in the same struct, since after computing the SIV tag it needs to be passed to the cipher.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful in the implementation of
aes-gcm-siv, as it allows for calling the newly re-addedfinalize_resetmethod, which is useful to avoid consumingselfwhen computing the tag.SIV mode encryption requires first computing the tag as a pass of POLYVAL over the plaintext, where the tag also functions as a synthetic initialization vector. With AES-GCM-SIV specifically, it also needs access to the original nonce, which is XORed into the tag.
Consuming
selfmeans it's not possible to store the cipher, POLYVAL, and nonce in the same struct, since after computing the SIV tag it needs to be passed to the cipher.