Skip to content

der: allow all blanket impls on ?Sized types #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Jul 24, 2024
Merged

der: allow all blanket impls on ?Sized types #1451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions der/src/encode.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ pub trait Encode {

impl<T> Encode for T
where
T: EncodeValue + Tagged,
T: EncodeValue + Tagged + ?Sized,
{
/// Compute the length of this value in bytes when encoded as ASN.1 DER.
fn encoded_len(&self) -> Result<Length> {
Expand Down Expand Up @@ -109,7 +109,10 @@ pub trait EncodePem: Encode + PemLabel {
}

#[cfg(feature = "pem")]
impl<T: Encode + PemLabel> EncodePem for T {
impl<T> EncodePem for T
where
T: Encode + PemLabel + ?Sized,
{
fn to_pem(&self, line_ending: LineEnding) -> Result<String> {
let der_len = usize::try_from(self.encoded_len()?)?;
let pem_len = pem::encapsulated_len(Self::PEM_LABEL, line_ending, der_len)?;
Expand Down
2 changes: 1 addition & 1 deletion der/src/tag.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ pub trait Tagged {
}

/// Types which are [`FixedTag`] always have a known [`Tag`] type.
impl<T: FixedTag> Tagged for T {
impl<T: FixedTag + ?Sized> Tagged for T {
fn tag(&self) -> Tag {
T::TAG
}
Expand Down