feat(cfb-mode): add Buffer{Encryptor|Decryptor}#17
feat(cfb-mode): add Buffer{Encryptor|Decryptor}#17newpavlov merged 4 commits intoRustCrypto:masterfrom
Conversation
This allows encrypting and decrypting based on multiple individual pieces of the data, rather than having to work with all data at once.
|
ping @tarcieri @newpavlov |
|
I'm personally fine with this, although I'm curious what @newpavlov has to say |
newpavlov
left a comment
newpavlov
left a comment
There was a problem hiding this comment.
Sorry for the late review! I have some minor nits/suggestions and the code can be improved in regards of eliminating unreachable panics, but otherwise I think it's good to merge. The comments about decryptor symmetrically apply to the encryptor as well. I will try to do the panics stuff later in a separate PR after releasing these changes.
|
@newpavlov should be ready for rereview |
|
Ping @dignifiedquire @newpavlov 2 months passed since last activity here, just want to make sure this PR is not forgotten and bitrot along with rpgp/rpgp#165 |
|
Oh, I indeed forgot about it during my break from GitHub. I will try to refresh my memory about this PR today or tomorrow and assuming there are no issues (which is quite likely), I will merge and release it right away. |
4 participants
This allows encrypting and decrypting based on multiple individual pieces of the data, rather than having to work with all data at once.