[Feat] #43 - CourseStorageVC UI 구현#47
Merged
lee-yeonwoo merged 7 commits intoRunnect:developfrom Jan 6, 2023
Merged
Conversation
dlwogus0128
approved these changes
Jan 6, 2023
Contributor
dlwogus0128
left a comment
There was a problem hiding this comment.
코드가 너무 어려워요... 리뷰가 어려워요.. 리드 멋지다!!!!!!!!!
| private let courseImageView = UIImageView().then { | ||
| $0.backgroundColor = .g3 | ||
| $0.contentMode = .scaleToFill | ||
| $0.layer.cornerRadius = 5 |
Contributor
There was a problem hiding this comment.
.scaleToFill을 하면 모가 다른가요?
Collaborator
Author
There was a problem hiding this comment.
https://sujinnaljin.medium.com/ios-%EC%82%AC%EC%A7%84%EC%9C%BC%EB%A1%9C-%EB%B3%B4%EB%8A%94-aspectfit-aspectfit-scaletofill-f41470d0191f
이거 한번 읽어보세요~! ImageView에는 다양한 contentMode가 있습니다!
| // MARK: - Methods | ||
|
|
||
| public func moveToPage(at index: Int) { | ||
| self.collectionView.scrollToItem(at: IndexPath(item: index, section: 0), at: .centeredHorizontally, animated: true) |
Contributor
There was a problem hiding this comment.
이게 내가 그린 코스 / 스크랩 코스 전환하는 부분인가요?
Collaborator
Author
There was a problem hiding this comment.
맞습니다..! 상단의 버튼을 클릭했을 때 내가 그린 코스/ 스크랩 코스가 자연스럽게 스크롤하면서 전환되도록 했습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌱 작업한 내용
🌱 PR Point
CourseListCVC를 구현하였습니다
📸 스크린샷
📮 관련 이슈