[Fix] #244 - 레이아웃 변경 작업을 하였습니다.#245
Merged
thingineeer merged 5 commits intoRunnect:developfrom Jan 13, 2024
Hidden character warning
The head ref may contain hidden characters: "#244---\uc774\ubbf8\uc9c0-\uae68\uc9d0-\uc774\uc288"
Merged
Conversation
UI도 약간 변경이 있었습니다.
코스 발견, 보관함, 코스 그리기의 레이아웃 변경 48 -> 56
들여쓰기, 필요없는 코드, 코드 컨벤션 을 지켜서 리팩터링 하였습니다.
thingineeer
changed the title
thingineeer
added
Refactor
513sojin
approved these changes
Jan 13, 2024
Collaborator
513sojin
left a comment
513sojin
left a comment
There was a problem hiding this comment.
UI 관련된 부분과 컨벤션 관련 수정
확인했습니다 !! 저도 앞으로 컨벤션 잘 맞춰 쓸게욥 ^,^ 수고하셨습니다 ~~
| GesturePublisher.Failure == S.Failure, GesturePublisher.Output | ||
| == S.Input { | ||
|
|
||
| func receive<S>(subscriber: S) where S: Subscriber, |
Collaborator
There was a problem hiding this comment.
확실히 줄바꿔주는게 낫네용!! 저도 앞으로 신경써서 작성해보겠습니다 👊🏻👊🏻
Collaborator
Author
There was a problem hiding this comment.
고민 해보다가 변경 했는데 좋게 봐주셔서 감사합니다. 🫠
| if let decodeData = try? JSONDecoder().decode(instance, from: response.data) { | ||
| completion(decodeData) | ||
| } else{ | ||
| } else { |
Collaborator
There was a problem hiding this comment.
아차차 요런 부분까지 확인해주다니.. 넘 꼼꼼해요 명진쌤 !!~! 고맙습니다 🙇🏻♀️
Collaborator
Author
There was a problem hiding this comment.
노란 경고 창이 떠서.. ㅎㅎ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
파일 변경이 뭐가 많아 보이는데 핵심은 맨 아래 스크린샷이 끝입니다. 🫨 나머지는 컨벤션 수정!
🌱 작업한 내용
내비게이션 바레이아웃 변경 48 -> 56 [피그마 따라감]보관함,러닝기록,업로드한 코스)🌱 PR Point
📸 스크린샷
📮 관련 이슈