[Feat] #20 - ActivityRecordInfo VC UI 구현#23
Merged
dlwogus0128 merged 6 commits intoRunnect:developfrom Jan 3, 2023
Hidden character warning
The head ref may contain hidden characters: "feat/#20-ActivityRecordInfoVC-UI-\uad6c\ud604"
Merged
Conversation
lsj8706
approved these changes
Jan 3, 2023
| } | ||
|
|
||
| horizontalDivideLine.snp.makeConstraints { make in | ||
| make.top.equalTo(activityRecordMapImage.snp.bottom).offset(7.87) |
Collaborator
There was a problem hiding this comment.
개인적으로 간격을 줄 때 소수를 주기 보다는 보통 반올림해서 줍니다. (사실 피그마에서 간격이 소수면 디자이너분한테 정수로 고쳐달라고 하는게 좋아요!)
|
|
||
| final class ActivityRecordInfoVC: UIViewController { | ||
|
|
||
| // MARK: - Variables |
Collaborator
There was a problem hiding this comment.
우리 Code Convention 상에서는
// MARK: - Properties <- 이게 더 적합한 거 같아요!
| private lazy var navibar = CustomNavigationBar(self, type: .titleWithLeftButton).setTitle("활동 기록") | ||
|
|
||
| private lazy var activityRecordTableView = UITableView().then { | ||
| $0.translatesAutoresizingMaskIntoConstraints = false |
Collaborator
There was a problem hiding this comment.
스냅킷을 사용한다면 이 구문은 없어도 됩니다! (스냅킷이 내부적으로 다 처리해줌)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌱 작업한 내용
🌱 PR Point
📸 스크린샷
📮 관련 이슈