提高getLocation函数的ie8兼容性#344
Merged
RubyLouvre merged 2 commits intoRubyLouvre:masterfrom Oct 4, 2018
ambit-tsai:master
Merged
Conversation
getLocation函数内容转义后为`return Object.assign({}, source.location, {/*略*/});`。
当使用babel-polyfill提供Object.assign语法支持时，会报错：`Object.prototype.propertyIsEnumerable: 'this' 不是 JavaScript 对象`。
使用for循环替换Object.assign进行属性复制。
判断条件写反了，去掉`!`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getLocation函数内容转义后为
return Object.assign({}, source.location, {/*略*/});。当使用babel-polyfill提供Object.assign语法支持时，会报错：
Object.prototype.propertyIsEnumerable: 'this' 不是 JavaScript 对象。使用for循环替换Object.assign进行属性复制。