Skip to content

Comments

Enable the Roo Code Cloud provider in evals#9492

Merged
cte merged 4 commits intomainfrom
cte/roo-code-cloud-provider-in-evals
Nov 22, 2025
Merged

Enable the Roo Code Cloud provider in evals#9492
cte merged 4 commits intomainfrom
cte/roo-code-cloud-provider-in-evals

Conversation

@cte
Copy link
Collaborator

@cte cte commented Nov 22, 2025

Screenshot 2025-11-22 at 12 06 22 AM

Important

Enable Roo Code Cloud provider in evals with model selection, job token support, and UI updates.

  • Behavior:
    • Adds Roo Code Cloud provider support in new-run.tsx with model selection and job token input.
    • Updates createRun in runs.ts to handle Roo Code Cloud settings.
    • Adds job token handling in processTask and processTaskInContainer in runTask.ts.
  • Database:
    • Adds jobToken column to runs table in 0003_simple_retro_girl.sql.
    • Updates schema in schema.ts to include jobToken.
  • UI Components:
    • Adds Checkbox component in checkbox.tsx.
    • Updates SettingsDiff in settings-diff.tsx to use a table layout.
  • Hooks:
    • Adds useFuzzyModelSearch in use-fuzzy-model-search.ts for model searching.
    • Adds useRooCodeCloudModels in use-roo-code-cloud-models.ts for fetching models.
  • Misc:
    • Removes systemPrompt from createRun parameters in runs.ts.

This description was created by Ellipsis for 560c5b0. You can customize this summary. It will automatically update as commits are pushed.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 22, 2025
@cte cte marked this pull request as ready for review November 22, 2025 07:45
@cte cte requested review from jr and mrubens as code owners November 22, 2025 07:45
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. Enhancement New feature or request labels Nov 22, 2025
@roomote
Copy link
Contributor

roomote bot commented Nov 22, 2025

Rooviewer Clock   See task on Roo Cloud

Review completed. Found 2 security issues that need to be addressed:

  • Shell injection vulnerability in processTaskInContainer - jobToken concatenated into docker command without escaping
  • Insecure token handling in runTask - jobToken exposed in process listings instead of using environment variables
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@cte cte merged commit 2ca9eac into main Nov 22, 2025
10 checks passed
@cte cte deleted the cte/roo-code-cloud-provider-in-evals branch November 22, 2025 08:06
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 22, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants