Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Nov 14, 2025

This PR attempts to address Issue #9268. Feedback and guidance are welcome.

Changes

  • Added moonshotai/kimi-k2-thinking-maas model to the VertexAI provider configuration
  • Configured with 256K context window (262,144 tokens for both max and context)
  • Set pricing: $0.60 per million input tokens, $2.50 per million output tokens
  • Model description: "Kimi K2 Thinking Model with 256K context window."

Testing

  • TypeScript compilation passes without errors
  • Linting checks pass
  • No existing tests found for vertex models specifically

Closes #9268


Important

Add moonshotai/kimi-k2-thinking-maas model to vertexModels in vertex.ts with specific configuration and pricing.

  • Model Addition:
    • Added moonshotai/kimi-k2-thinking-maas to vertexModels in vertex.ts.
    • Configured with 16,384 max tokens and 262,144 context window.
    • Pricing set at $0.60 per million input tokens and $2.50 per million output tokens.
    • Description: "Kimi K2 Thinking Model with 256K context window."
  • Testing:
    • TypeScript compilation and linting checks pass.
    • No specific tests for vertex models found.
  • Issue Closure:

This description was created by Ellipsis for 7f695f0. You can customize this summary. It will automatically update as commits are pushed.

- Added moonshotai/kimi-k2-thinking-maas model configuration
- Configured with 256K context window
- Set pricing at $0.60 input / $2.50 output
- Closes #9268
@roomote roomote bot requested review from cte, jr and mrubens as code owners November 14, 2025 15:59
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Enhancement New feature or request labels Nov 14, 2025
@roomote
Copy link
Contributor Author

roomote bot commented Nov 14, 2025

Rooviewer Clock   See task on Roo Cloud

Review complete. The implementation correctly adds the Kimi K2 thinking model to VertexAI with proper configuration. All previously flagged issues have been resolved.

  • Update maxTokens from 262_144 to 16_384 per maintainer request
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 14, 2025
@nitishchauhan0002
Copy link

Guys, @mrubens @cte @jr Hope you're all doing well!
When you get a chance, could you please review the PR and proceed with the merge if everything looks good?

I'd really appreciate your support on this. Thank you in advance for your time and help!

@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jan 6, 2026
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jan 6, 2026
@hannesrudolph hannesrudolph reopened this Jan 6, 2026
@github-project-automation github-project-automation bot moved this from Done to Triage in Roo Code Roadmap Jan 6, 2026
@github-project-automation github-project-automation bot moved this from Done to New in Roo Code Roadmap Jan 6, 2026
@hannesrudolph
Copy link
Collaborator

@roomote set the maxTokens to 16_384

@roomote
Copy link
Contributor Author

roomote bot commented Jan 6, 2026

Rooviewer Clock   See task on Roo Cloud

Review complete. Found 1 issue that needs to be addressed before merging.

  • Update maxTokens from 262_144 to 16_384 per maintainer request

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph moved this from Triage to PR [Needs Review] in Roo Code Roadmap Jan 6, 2026
@roomote
Copy link
Contributor Author

roomote bot commented Jan 6, 2026

Fixaroo Clock   See task on Roo Cloud

Updated maxTokens from 262_144 to 16_384 for the Kimi K2 model as requested.

View commit | Revert commit

@hannesrudolph hannesrudolph added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jan 6, 2026
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jan 20, 2026
@cte cte deleted the feat/add-kimi-k2-vertex-model branch January 20, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request lgtm This PR has been approved by a maintainer PR - Needs Review size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Request to add Kimi K2 thinking to Google VertexAI provider

5 participants