-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Make Posthog telemetry the default #7909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've reviewed the changes to make telemetry opt-out by default. I have some critical concerns about the privacy implications and UI behavior that need attention.
b2a86c2 to
f86c630
Compare
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
daniel-lxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Important
Telemetry is now enabled by default, with UI and privacy policy updates to reflect this change, and users can opt-out via settings.
updateTelemetryState()inTelemetryService.tsandwebviewMessageHandler.tsto reflect default enabled state.TelemetryBannerinTelemetryBanner.tsxto remove allow/deny buttons, adds close button.TelemetryBanneronly if telemetry setting is "unset".PRIVACY.mdto reflect telemetry is collected by default.didUserOptIntoisOptedIninTelemetryService.tsandtelemetry.ts.This description was created by
for f86c630. You can customize this summary. It will automatically update as commits are pushed.