feat: gracefully handle removed models in UI#7419
Conversation
- Show removed models in dropdown with '(unavailable)' label - Allow users to keep selected model even if removed from catalog - Clear removed models when switching providers - Add comprehensive test coverage for removed model scenarios - Add internationalization support for unavailable model label
88c576a to
931db0f
Compare
Code Review Summary✅ No issues found - The implementation is clean and follows best practices. Review CompletedI've thoroughly reviewed this PR and found no bugs, security issues, or breaking changes. The implementation correctly:
The existing bot review comments (#1-#5) are style suggestions rather than critical issues. The code is ready for merge. Latest Commit Review (3889f6a)Reviewed the latest commit that removes the deprecated |
| description: | ||
| "A stealth reasoning model that is blazing fast and excels at agentic coding, accessible for free through Roo Code Cloud for a limited time. (Note: prompts and completions are logged by the model creator and used to improve the model.)", | ||
| }, | ||
| } as const satisfies Record<string, ModelInfo> |
There was a problem hiding this comment.
Changing type from Record<RooModelId, ModelInfo> to Record<string, ModelInfo> weakens type safety. If this is intended for flexibility, please add a clarifying comment.
|
Do we still need this one? Or is it duplicative of the work around deprecated models? |
|
@mrubens This can be closed |
Summary
This PR implements graceful handling for models that have been removed from the catalog but are still selected in user configurations.
Changes
Behavior
When a model is removed from the catalog but still selected:
When switching providers:
Testing
All tests pass successfully:
Related Issues
Similar to #7392 but focused on graceful degradation rather than hiding providers.
Important
Enhances UI to handle removed models gracefully, adds internationalization for 'unavailable' label, and includes tests for robustness.
ApiOptions.tsx.ApiOptions.tsx.settings.jsonfiles.ApiOptions.spec.tsx.roo/sonictoroo.ts.This description was created by
for 3889f6a. You can customize this summary. It will automatically update as commits are pushed.