fix: prevent "Current ask promise was ignored" error when cancelling tasks#5957
Closed
roomote[bot] wants to merge 1 commit intomainfrom
Closed
fix: prevent "Current ask promise was ignored" error when cancelling tasks#5957roomote[bot] wants to merge 1 commit intomainfrom
roomote[bot] wants to merge 1 commit intomainfrom
Conversation
…tasks - Clear ask promise state (askResponse, askResponseText, askResponseImages) in abortTask() - Add abort check in ask() method to handle task cancellation gracefully - Clear ask promise state at the beginning of resumeTaskFromHistory() - This prevents the error that occurred when cancelling a task with an active ask promise Fixes #5955
Member
|
Should be handled by #5544 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #5955 where task history gets unexpectedly truncated after cancelling a running task.
Problem
When a task was cancelled while an
askpromise was waiting for user response, the promise state was not properly cleared. This caused the "Current ask promise was ignored" error when trying to resume the task from history.Solution
askResponse,askResponseText,askResponseImages) inabortTask()methodask()method to handle task cancellation gracefully while waiting for responseresumeTaskFromHistory()to ensure clean stateTesting
Fixes #5955
Important
Fixes issue #5955 by clearing
askpromise state inabortTask()andresumeTaskFromHistory()methods inTask.tsto prevent errors when cancelling tasks.askpromise state (askResponse,askResponseText,askResponseImages) inabortTask()andresumeTaskFromHistory()methods inTask.ts.ask()method to handle task cancellation while waiting for response.ClineProviderpass.This description was created by
for e0b3871. You can customize this summary. It will automatically update as commits are pushed.