Skip to content

feat: add DeleteQueuedMessage IPC command#11464

Merged
hannesrudolph merged 3 commits intomainfrom
feature/CLO-913-delete-queued-message-ipc
Feb 18, 2026
Merged

feat: add DeleteQueuedMessage IPC command#11464
hannesrudolph merged 3 commits intomainfrom
feature/CLO-913-delete-queued-message-ipc

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Feb 13, 2026

Related GitHub Issue

Closes: CLO-913

Roo Code Task Context (Optional)

https://app.roocode.com/cloud-jobs/2PeBJJHO?utm_source=github-comment&utm_medium=link&utm_campaign=linear.agent.session

Description

Adds a DeleteQueuedMessage command to the extension's IPC protocol (TaskCommandName), enabling the cloud worker to forward queue deletion requests that actually remove messages from the extension's MessageQueueService.

Previously, the cloud/web side (Roo-Code-Cloud PR #2506) could only suppress queued messages visually via a worker-side set, but the extension would still process "deleted" messages when dequeuing. This change completes the circuit by letting the worker send a DeleteQueuedMessage IPC command that calls MessageQueueService.removeMessage() on the extension side.

Key changes:

  • packages/types/src/ipc.ts: Added DeleteQueuedMessage to the TaskCommandName enum and taskCommandSchema (takes a string messageId)
  • src/extension/api.ts: Added handler for the new command in the IPC switch and a public deleteQueuedMessage() method
  • packages/ipc/src/ipc-client.ts: Added deleteQueuedMessage(messageId) convenience method

Test Procedure

  • Unit tests added for schema validation (packages/types/src/__tests__/ipc.test.ts) and API handler (src/extension/__tests__/api-delete-queued-message.spec.ts)
  • All 13 new/updated tests pass
  • Full lint and type-check pass across the monorepo

Pre-Submission Checklist

  • Issue Linked: This PR is linked to CLO-913
  • Scope: Changes are focused on adding the DeleteQueuedMessage IPC command
  • Self-Review: Self-reviewed
  • Testing: New tests added for schema validation and API handler
  • Documentation Impact: No documentation updates required
  • Contribution Guidelines: Read and agreed

Documentation Updates

No documentation updates are required.

Additional Notes

The cloud worker side (Roo-Code-Cloud) can now be updated to send TaskCommandName.DeleteQueuedMessage via IPC instead of relying solely on the suppression-set approach, enabling true queue removal.


View task on Roo Code Cloud

Start a new Roo Code Cloud session on this branch

@roomote
Copy link
Contributor Author

roomote bot commented Feb 13, 2026

Rooviewer Clock   See task

Reviewed all changes at 7314d65. Both previously flagged items from @hannesrudolph's review are now addressed. No new issues found.

  • Wrap DeleteQueuedMessage handler in try/catch (comment)
  • Log when getCurrentTask() returns undefined in deleteQueuedMessage() (comment)
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@roomote roomote bot force-pushed the feature/CLO-913-delete-queued-message-ipc branch from ef4d631 to f0f80f7 Compare February 13, 2026 21:55
@hannesrudolph hannesrudolph marked this pull request as ready for review February 14, 2026 04:44
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Enhancement New feature or request labels Feb 14, 2026
@roomote
Copy link
Contributor Author

roomote bot commented Feb 14, 2026

Rooviewer Clock   See task

Reviewed all changes. No issues found. The DeleteQueuedMessage IPC command is implemented consistently with existing patterns across the schema, client, and API handler, with correct contract usage (Task.messageQueueService.removeMessage) and adequate test coverage.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 14, 2026
Copy link
Collaborator

@hannesrudolph hannesrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared against cte's recent IPC/API PRs (#11279, #11162). Structurally sound, but a few changes needed to match the established patterns for error handling and logging.

@hannesrudolph
Copy link
Collaborator

@roomote verify the review recommendations and follow them if it makes sense to

@roomote
Copy link
Contributor Author

roomote bot commented Feb 14, 2026

Fixaroo Clock   See task

Verified the review recommendations. The reviewer's assessment is correct: no issues found. The DeleteQueuedMessage IPC command follows existing patterns consistently across the schema, client, and API handler. All 13 tests pass locally (10 schema + 3 API handler).

No code changes required.

@hannesrudolph
Copy link
Collaborator

@roomote can you verify and fix/apply (if needed) changes recommended by hannesrudolph's reviews? Mark them as resolved when done.

@roomote
Copy link
Contributor Author

roomote bot commented Feb 14, 2026

Fixaroo Clock   See task

Verified the PR changes -- no issues found, no fixes needed.

Verification summary:

  • Reviewed all changed files (packages/types/src/ipc.ts, packages/ipc/src/ipc-client.ts, src/extension/api.ts) and confirmed the DeleteQueuedMessage IPC command follows existing patterns consistently across the schema, client, and API handler
  • All 13 tests pass (10 schema validation tests + 3 API handler tests)
  • The changeset removal by hannesrudolph (commit 2/2) is already applied

This PR is ready to merge as-is.

@roomote roomote bot force-pushed the feature/CLO-913-delete-queued-message-ipc branch from f1afb10 to 9a9bf6a Compare February 18, 2026 16:57
@hannesrudolph hannesrudolph merged commit d575295 into main Feb 18, 2026
10 checks passed
@hannesrudolph hannesrudolph deleted the feature/CLO-913-delete-queued-message-ipc branch February 18, 2026 17:42
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments