fix: replace swiper/element/bundle import with swiper/element#1216
Open
Akshansh0612 wants to merge 1 commit intoRocketChat:developfrom
Open
fix: replace swiper/element/bundle import with swiper/element#1216Akshansh0612 wants to merge 1 commit intoRocketChat:developfrom
Akshansh0612 wants to merge 1 commit intoRocketChat:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Description
This PR fixes an incorrect import path used in the ImageGallery Swiper component.
Previously the code imported:
import { register } from 'swiper/element/bundle';
This caused module resolution errors in Storybook and tests because the module could not be resolved properly.
The import has been updated to:
import { register } from 'swiper/element';
which works correctly with the installed Swiper dependency.
Changes Made
packages/react/src/views/ImageGallery/Swiper.jsswiper/element/bundlewithswiper/elementVerification
yarn storybookIssue
Fixes #1191