Fix gitmodules handling for clone command#3
Open
Kinokin wants to merge 2 commits intoReedbeta:mainfrom
Open
Conversation
Kinokin
commented
Jul 25, 2022
- handle relative submodule url
- handle special branch '.'
Change-Id: I6de67e5961cd1ff8a8d72e741d23c7c78bb8c7b3
Change-Id: Ie3422c05529497bfa3cf1d99ec33227f418c8996
Owner
|
Thanks for the PR! I think the code can likely be simplified a lot using os.path.relpath and such rather than parsing the path yourself. See how I'm doing it for the submodule paths a few lines earlier: Also, it looks like you used 3-space indents instead of 4 - I'd appreciate if you can clean that up. 🙂 |
Author
|
Hi Nathan, yes, its a quick hack to get an experiment working. I can't spend any more time on this, sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.