fix: escape symbols in the samples lang name#703
Merged
AntonKozachuk merged 3 commits intomasterfrom May 25, 2022
Merged
Conversation
AntonKozachuk
force-pushed
the
fix/hash-symbol-in-path
branch
from
71ca244 to
de85d41
Compare
Contributor
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from 6db8609 |
Collaborator
|
Thanks. Could you add a few test cases? |
tatomyr
reviewed
May 24, 2022
AntonKozachuk
force-pushed
the
fix/hash-symbol-in-path
branch
2 times, most recently
from
ba745eb to
b573749
Compare
tatomyr
reviewed
May 25, 2022
AntonKozachuk
force-pushed
the
fix/hash-symbol-in-path
branch
from
b573749 to
7c1e86a
Compare
AntonKozachuk
force-pushed
the
fix/hash-symbol-in-path
branch
from
7c1e86a to
6db8609
Compare
tatomyr
approved these changes
May 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Resolve an issue with the # symbol in C# code samples is not encoded properly if we run
openapi splitcommand.Reference
Fix #685
Testing
Checked with several lang names, including C#.
Screenshots (optional)
Check yourself
Security