Skip to content

chore: add missing array types for 3.1#694

Merged
AntonKozachuk merged 3 commits intomasterfrom
update-array-types
May 23, 2022
Merged

chore: add missing array types for 3.1#694
AntonKozachuk merged 3 commits intomasterfrom
update-array-types

Conversation

@AntonKozachuk
Copy link
Copy Markdown
Contributor

What/Why/How?

Add missing Array props to type tree: https://json-schema.org/understanding-json-schema/reference/array.html

Reference

Testing

N/a

Screenshots (optional)

N/a

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@AntonKozachuk AntonKozachuk requested a review from tatomyr May 19, 2022 11:44
@AntonKozachuk AntonKozachuk self-assigned this May 19, 2022
Copy link
Copy Markdown
Member

@RomanHotsiy RomanHotsiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@github-actions
Copy link
Copy Markdown
Contributor

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 65.6% 2607/3974
🔴 Branches 59.76% 1430/2393
🔴 Functions 57.5% 414/720
🟡 Lines 65.81% 2410/3662

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from d80408d

@AntonKozachuk AntonKozachuk merged commit e381476 into master May 23, 2022
@AntonKozachuk AntonKozachuk deleted the update-array-types branch May 23, 2022 13:51
@tatomyr tatomyr mentioned this pull request May 26, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants