Add Coccinelle lint checks for non-_RO accessors used with pointers to const
#7622
+81
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Benjamin Schwendinger <52290390+ben-schwen@users.noreply.github.com>
Co-authored-by: Benjamin Schwendinger <52290390+ben-schwen@users.noreply.github.com>
Keep the casts because they are currently necessary for the integer64 case.
ben-schwen
requested review from
HughParsonage,
ben-schwen and
tdhock
as code owners
ben-schwen
reviewed
Jan 24, 2026
MichaelChirico
approved these changes
Jan 25, 2026
Member
MichaelChirico
left a comment
MichaelChirico
left a comment
There was a problem hiding this comment.
LGTM, merge when you're ready 
Co-authored-by: Michael Chirico <chiricom@google.com>
This reverts commit 70d37da.
Setting $c_obj instead of $path caused the error messages to be zero-length due to the latter being returned as NULL. Co-Authored-By: Michael Chirico <chiricom@google.com> Co-Authored-By: Benjamin Schwendinger <52290390+ben-schwen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rescued from #7619. As of 9b034c8, the check passes locally without complaining.